Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glimmer2 Support #18

Closed
rlivsey opened this issue Sep 23, 2016 · 1 comment
Closed

Glimmer2 Support #18

rlivsey opened this issue Sep 23, 2016 · 1 comment

Comments

@rlivsey
Copy link
Contributor

rlivsey commented Sep 23, 2016

Looks like Glimmer2 changes the way the dom renderer work, as this no longer returns anything and so it asserts:

    let emberRenderer = this.get('renderer');
    let dom = emberRenderer && emberRenderer._dom;
    assert('Unable to get renderer dom helper', !!dom);
bantic added a commit that referenced this issue Oct 13, 2016
@bantic
Run tests on ember beta, release, canary
4d1ea6c 
 * Fix failing tests when using ember with glimmer2.
 * Access DOM helper using a method that is safe for both pre-glimmer2 and
glimmer2.
 * Wrap the renderedMobiledoc documentFragment in a wrapper div
   (necessary for glimmer2 teardown, see
   glimmerjs/glimmer-vm#331 and
   yapplabs/ember-wormhole#66 (comment))
 * Fixes #18.
 * Update travis node version.
 * Update package keywords and description.
@bantic bantic mentioned this issue Oct 13, 2016
Merged
@bantic
Copy link
Contributor

bantic commented Oct 19, 2016

fix released in v0.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bantic @rlivsey