-
Notifications
You must be signed in to change notification settings - Fork 150
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clear selection in editor#destroy, make editorDomRenderer#destroy safer
* Add a `hasRendered` property to Editor and EditorDomRenderer instances. * If an editor is destroyed when it has an active cursor, clear that selection. This fixes an issue with calling `editor.cursor.offsets` when the editor's dom element is selected but the editor has not yet rendered. See bustle/ember-mobiledoc-editor#39 * Update Cursor `hasCursor` and `hasSelection` methods to always return false when the editor has not yet rendered. * Fix a bug when calling EditorDomRenderer#destroy if it has not yet rendered.
- Loading branch information
Showing
5 changed files
with
84 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters