Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting text that contains a newline throws an error #462

Closed
YoranBrondsema opened this issue Aug 23, 2016 · 2 comments
Closed

Pasting text that contains a newline throws an error #462

YoranBrondsema opened this issue Aug 23, 2016 · 2 comments
Assignees
@bantic

Comments

@YoranBrondsema
Copy link
Collaborator

I think this is a regression introduced by #459. Inserting text with newlines inside a list works, as per the fix. However, inserting text with newlines outside of a list, for instance in an empty Mobiledoc instance, fails.

error
@bantic
Copy link
Collaborator

bantic commented Aug 24, 2016

Darn, I knew that fix yesterday seemed too simple.
I will address this today and expand the test coverage for the post-insertion tests. Thanks for reporting!

@bantic bantic self-assigned this Aug 24, 2016
bantic added a commit that referenced this issue Aug 24, 2016
@bantic
Fix insertion into blank section
63f2ed5 
Fixes #462
bantic added a commit that referenced this issue Aug 24, 2016
@bantic
Fix insertion into blank section
98623c8 
Fixes #462
@bantic bantic mentioned this issue Aug 24, 2016
Closed
bantic added a commit that referenced this issue Aug 24, 2016
@bantic
Fix insertion into blank section
6229148 
* Refactor #insertPost tests to use builder and editor DSL.
* Add test helper editor DSL `Helpers.editor.buildFromText(dsl, editorOptions)`
* Add test helper `retargetRange` to retarget a range from one post to
  another. Helps with asserting that the editor's range matches the one
  from the DSL

Fixes #462
@bantic bantic mentioned this issue Aug 24, 2016
Merged
bantic added a commit that referenced this issue Aug 24, 2016
@bantic
fix(paste): Fix insertion into blank section (#466)
a3d274d 
* Refactor #insertPost tests to use builder and editor DSL.
* Add test helper editor DSL `Helpers.editor.buildFromText(dsl, editorOptions)`
* Add test helper `retargetRange` to retarget a range from one post to
  another. Helps with asserting that the editor's range matches the one
  from the DSL

Fixes #462
@bantic
Copy link
Collaborator

bantic commented Aug 24, 2016

released in v0.10.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bantic bantic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bantic @YoranBrondsema