Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI import statement #492

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Fix UI import statement #492

merged 1 commit into from
Sep 13, 2016

Conversation

joshfrench
Copy link
Contributor

My bad! I botched the import on Mobiledoc.UI. I had a bit of a challenge trying to verify this in your dev env while being unfamiliar with Broccoli and Ember, do you mind checking it before you ship this patch? Thanks!

@bantic
Copy link
Collaborator

bantic commented Sep 13, 2016

@joshfrench No worries. This looks right to me. I will test it out more fully later but can release a beta now.

@bantic bantic merged commit 08c0c24 into bustle:master Sep 13, 2016
@bantic
Copy link
Collaborator

bantic commented Sep 13, 2016

@joshfrench This is released on v0.10.11-beta.1 if you want to make sure it works now for you.

@joshfrench
Copy link
Contributor Author

The beta works for me, thanks and sorry for that. I just pushed another commit to this branch that exposes UI, Range, and Position as named imports in addition to Editor, if you feel like grabbing that as well. (Otherwise they remain available at Mobiledoc.default.*)

@bantic
Copy link
Collaborator

bantic commented Sep 14, 2016

Cool, yeah, I'm pulling that in on #493. thanks!

@bantic
Copy link
Collaborator

bantic commented Sep 14, 2016

released in v0.10.11

@joshfrench
Copy link
Contributor Author

Thanks Cory!

johnelliott pushed a commit to dailybeast/mobiledoc-kit that referenced this pull request Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants