Editor commands tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add `Helpers.dom.triggerKeyEvent` for simulating key events * add `Helpers.dom.triggerEvent` for simulating mouse events * Add View#destroy, destroy all views when destroying editor
bantic
force-pushed
the
editor-commands-tests
branch
from
6d3fbdd
to
e04761c
Compare
bantic
force-pushed
the
editor-commands-tests
branch
from
efa2d70
to
6e30ac8
Compare
|
@mixonic this is finally ready to go — travis is happy, the acceptance tests are running. |
|
|
||
| selectedText = 'IS A'; | ||
| Helpers.dom.selectText(selectedText, editorElement); | ||
| Helpers.dom.triggerEvent(document, 'mouseup'); |
There was a problem hiding this comment.
You could just add the async control here:
window.QUnit.stop();
setTimeout(window.QUnit.start, 10);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mixonic for you
editor#destroycleanup of views (specifically, removing the toolbar)hasElementandhasNoElementassertionsselectText(text, containingElement),triggerEvent,triggerKeyEventbring inKeyboardEventpolyfill for testsThese tests now pass in all mac browsers and phantomjs.
There is an existing failing test in Firefox that is not from this PR.