Correctly interpret a reported selection of the editor element #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Firefox, typing Command-A changes the selection to have the editor element as the focus and anchor node (other browsers select the first and last text nodes in the editor element). Changes Position.fromNode to correctly detect this and return the correct Position Also some cleanup in tests and removed usage of `isMarkerable` functions throughout the codebase in favor of `section.isMarkerable` property. fixes #215
bantic
added a commit
that referenced
this pull request
Nov 9, 2015
Correctly interpret a reported selection of the editor element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firefox, typing Command-A changes the selection to have the
editor element as the focus and anchor node (other browsers select the
first and last text nodes in the editor element). Changes
Position.fromNode to correctly detect this and return the correct
Position
Also some cleanup in tests and removed usage of
isMarkerablefunctionsthroughout the codebase in favor of
section.isMarkerableproperty.fixes #215