Export toggleLink #491
Merged
Export toggleLink #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @joshfrench this is excellent. Thanks for adding the thorough jsdoc, as well! |
|
released in v0.10.10. thanks @joshfrench ! |
johnelliott
pushed a commit
to dailybeast/mobiledoc-kit
that referenced
this pull request
Feb 7, 2017
* WIP: expose `toggleLink` as public method * Object.keys flunks outside of browser env * Unit tests for UI.toggleLink * Export UI for reuse by editor kits * DRY up renderIntoAndFocusTail * Document UI.toggleLink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[re: #485] Makes
Mobiledoc.UI.toggleLinka public function so that alternate editor kits can reuse and/or customize the core URL prompt. (I18n, anyone?)Incidentally extracts
renderIntoAndFocusTailintotest-helpersas it was duplicated across several files.