Add Key, test for printable character on keydown when selection
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantic
force-pushed
the
handle-keystroke-50
branch
from
5f9b99f
to
c015ef4
Compare
bantic
force-pushed
the
handle-keystroke-50
branch
from
c015ef4
to
83deff5
Compare
mixonic
added a commit
that referenced
this pull request
Aug 17, 2015
Add `Key`, test for printable character on keydown when selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a whitelist of keycodes to determine if a character is printable.
There will probably need to be additions to that heuristic in the future,
but this feels pretty reasonable for a first approach.
This fixes the issue of content editable adding garbage HTML when you select two text nodes
that have different styling (e.g., part of a heading and part of a plain-text section) and
hit a character. Chrome inserts a
spanto try to preserve the styling of the plain-textwhen it removes the selection and joins the plain-text to the heading.
Fixes #50
cc @mixonic