Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mobiledoc with no content should render placeholder #125

Closed
bantic opened this issue Sep 14, 2015 · 0 comments · Fixed by #127
Closed

mobiledoc with no content should render placeholder #125

bantic opened this issue Sep 14, 2015 · 0 comments · Fixed by #127
Assignees
@bantic

Comments

@bantic
Copy link
Collaborator

bantic commented Sep 14, 2015

When the mobiledoc has no sections, a placeholder element should be rendered. This prevents an issue when removing the final card from a mobiledoc that has no markup sections.
@bantic bantic self-assigned this Sep 14, 2015
bantic added a commit that referenced this issue Sep 14, 2015
@bantic
Handle blank mobiledoc in editor
7af6f9b 
 * Rename Section methods semantically
 * add "simple-card" demo, with "remove" button
 * Clean up cursor detection and embedIntent
 * Add Position.emptyPosition and Range.emptyRange
 * allow mobiledoc to have 0 sections
 * add Post#isBlank
 * Add tests for typing in blank mobiledoc
 * Tests for removing the last item (e.g., card) in a mobiledoc
 * Ensure that replaceSection works when section is undefined

fixes #125
bantic added a commit that referenced this issue Sep 14, 2015
@bantic
Handle blank mobiledoc in editor
0c0dba8 
 * Rename Section methods semantically
 * add "simple-card" demo, with "remove" button
 * Clean up cursor detection and embedIntent
 * Add Position.emptyPosition and Range.emptyRange
 * allow mobiledoc to have 0 sections
 * add Post#isBlank
 * Add tests for typing in blank mobiledoc
 * Tests for removing the last item (e.g., card) in a mobiledoc
 * Ensure that replaceSection works when section is undefined
 * Add empty mobiledoc to demo

fixes #125 #35 #71
@bantic bantic mentioned this issue Sep 14, 2015
Merged
bantic added a commit that referenced this issue Sep 14, 2015
@bantic
Handle blank mobiledoc in editor
d60c0dc 
 * Rename Section methods semantically
 * add "simple-card" demo, with "remove" button
 * Clean up cursor detection and embedIntent
 * Add Position.emptyPosition and Range.emptyRange
 * allow mobiledoc to have 0 sections
 * add Post#isBlank
 * Add tests for typing in blank mobiledoc
 * Tests for removing the last item (e.g., card) in a mobiledoc
 * Ensure that replaceSection works when section is undefined
 * Add empty mobiledoc to demo

fixes #125 #35 #71
bantic added a commit that referenced this issue Sep 14, 2015
@bantic
Handle blank mobiledoc in editor
dca9722 
 * Rename Section methods semantically
 * add "simple-card" demo, with "remove" button
 * Clean up cursor detection and embedIntent
 * Add Position.emptyPosition and Range.emptyRange
 * allow mobiledoc to have 0 sections
 * add Post#isBlank
 * Add tests for typing in blank mobiledoc
 * Tests for removing the last item (e.g., card) in a mobiledoc
 * Ensure that replaceSection works when section is undefined
 * Add empty mobiledoc to demo

fixes #125 #35 #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bantic bantic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle blank mobiledoc in editor bustle/mobiledoc-kit
1 participant
@bantic