Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withParam with empty strings - wrong output url #222

Closed
ligal opened this issue Aug 30, 2017 · 1 comment
Closed

withParam with empty strings - wrong output url #222

ligal opened this issue Aug 30, 2017 · 1 comment

Comments

@ligal
Copy link

ligal commented Aug 30, 2017

Using -
resource("/api").withParam("x","").withParam("y","")

expected output - "/api?x=&y="
current output - "/api?x"

some web apis need all their params to find the correct route.
this is how i found out about this issue.

please advice.
@pcantrell
Copy link
Member

Ah, that's a bug. Mysterious!

(The correct result should be /api?x&y, not /api?x=&y=. Siesta drops the = for empty string param values.)

pcantrell added a commit that referenced this issue Sep 3, 2017
@pcantrell
Make withParam(…) preserve params with empty values
f45933e 
Fixes #222
@pcantrell pcantrell mentioned this issue Sep 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcantrell @ligal