Separate SiestaUI module & directory reorg #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the
Siesta
module into two modules,Siesta
andSiestaUI
. The latter containsRemoteImageView
andResourceStatusOverlay
, and is iOS-only (at least for now).These is now a separate
SiestaUI
framework in the Xcode project, and a separateSiesta/UI
subspec in the podspec.This PR also includes some other minor file reorg & cleanup.
Advantages
The big reason to do this now is that (1) it comes with a directory re-org and (2) Swift 3 is imminent. Moving all these files while still in the 2.2 branch of the code will greatly ease porting of any fixes to and from the 3.0 branch.
Drawbacks
Clients that use Carthage or build from the Xcode project directly will now need to import a second module to use UI helpers:
However, Cocoapods bundles all subspecs into a single framework, so client apps that use Cocoapods will still only
import Siesta
. This is potentially confusing. Anyone know if there’s a way to make a subspec build a separate framework?