Extension safe library #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the `Allow app extension API only` option. Because there are no non-safe apis used in the library it can be enabled without producing any warnings. This change will the `unsafe api` warning if one uses the framework in an app extension. SiestaUI can't be labeled `app extension safe`, because of it's NetworkActivityIndicator.
|
This looks good. Thanks! I can imagine someone conceivably wanting to use ResourceStatusOverlay or some derivate in an app extension, but we can solve that problem when we come to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
Allow app extension API onlyoption.Because there are no non-safe APIs used in the library, it can be enabled without producing any warnings.
This change will hide the
unsafe apiwarning, if one uses the framework in an app extension.SiestaUI can't be labeled
app extension safe, because of it's NetworkActivityIndicator.