Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White Button in Power Up and Power Down modal should be labeled Cancel #2039

Closed
ng-gist opened this issue Jul 6, 2018 · 2 comments
Closed
Assignees
Labels
Projects
Milestone

Comments

@ng-gist
Copy link
Contributor

ng-gist commented Jul 6, 2018

Expected behavior

White button label in Power Up and Power Down modal should be "Cancel"

Actual behavior

White button label in Power Up and Power Down modal is "Delete"

How to reproduce

  1. Login to busy.org
  2. Go to wallet.
  3. Click on Power Up\Power Down
  4. Check the label of the white button.

image

Technical Analysis

PowerUpOrDown.js

cancelText={intl.formatMessage({ id: 'cancel', defaultMessage: 'Cancel' })}

Internationalization reads cancel key value from en-US.json and defaults to 'Cancel' if no value is found.

en-US.json

"cancel": "Delete",

Value of cancel key is set to Delete instead of Cancel

  • Browser: Google Chrome ( 66.0.3359.181 Version)
  • Operating system: OSX 10.11.6
@Sekhmet
Copy link
Contributor

Sekhmet commented Jul 6, 2018

I will keep this issue open until we update CrowdIn setup and translations.

@Sekhmet Sekhmet self-assigned this Jul 10, 2018
@Sekhmet Sekhmet added the bug label Jul 10, 2018
@Sekhmet Sekhmet added this to Backlog 💡 in Workflow via automation Jul 10, 2018
@Sekhmet Sekhmet added this to the v2.5.2 milestone Jul 10, 2018
@Sekhmet Sekhmet moved this from Backlog 💡 to Dev in progress 🏗 in Workflow Jul 10, 2018
@Sekhmet Sekhmet moved this from Dev in progress 🏗 to Dev done 😎 in Workflow Jul 11, 2018
@Sekhmet
Copy link
Contributor

Sekhmet commented Jul 11, 2018

Now the correct translation is used for that after CrowdIn sync.
image

@Sekhmet Sekhmet closed this as completed Jul 11, 2018
Workflow automation moved this from Dev done 😎 to Ready to ship 🚀 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Workflow
  
Ready to ship 🚀
Development

No branches or pull requests

2 participants