adds input value as fn #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @AutoSponge! |
busypeoples
reviewed
Dec 16, 2017
| reduce((result, key) => { | ||
| const value = input[key] | ||
| export const validate = curry((successFn: Function, failFn: Function, spec: Object, input: Object): Object => { | ||
| const inputFn = typeof input === 'function' ? input : (key?: string) => key ? input : input |
There was a problem hiding this comment.
input : (key?: string) => key ? input : input, why don't we just return (_key?: string) => input?
We don't seem to be doing anything with key anyway.
There was a problem hiding this comment.
It's clearer in the test. key is optional as you can also provide a thunk or bound fn that ignores key.
There was a problem hiding this comment.
Ok, let's keep the key ? input : input part, I don't mind and adapt when needed. Just want to make sure it's not confusing to people reading the code.
There was a problem hiding this comment.
Will merge tomorrow and release a new version. Thanks for all the work @AutoSponge!
|
This is good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #95