Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a tab is torn out, content bindings' setter gets called infinitely #49

Closed
dasjestyr opened this issue Oct 4, 2015 · 5 comments
Closed

Comments

@dasjestyr
Copy link

Out of the box, I replaced my tab control, which uses an item template for the tabs and content template for each tab's content. Immediately, when I tear the tab out, I was able to see that each property that is being bound to a property on the view model had its setter called infinitely. This is a bigger problem because I have an event fire to do some work each time one of those properties change.

@ButchersBoy
Copy link
Owner

Hi, typically whenever these issues get reported it is because the tab has been put into an existing application, and a bit of rework needs to be done. Can you stuck a break point in the binding (maybe use PropertyChangedCallback) to try and decipher where it's coming from? If you can post a test project which illustrates the problem I can try and debug it.

@dasjestyr
Copy link
Author

Hi, sorry for the delay, it's been a long week. So, the only thing in the project that touches the setter on these properties is the view, so I'm not sure how to look for the cause. What I'll do (probably tomorrow) is branch my project and drop in your tab control again and then I'll get you that copy. Thanks

@ButchersBoy
Copy link
Owner

Is this an issue still? If so, post a repo please. Otherwise I'll close.

@dasjestyr
Copy link
Author

It is. Sorry, I've been swamped. I will come back to this hopefully this weekend or next. I'll have to find it again and then I'll just point you at the repo and tell you exactly where it is. I hope we can get it figured out as I'd love to use the library. I have a "competitor" now that is using it and it looks great, but my functionality is far better ;)

@dasjestyr
Copy link
Author

I gutted everything and rebuilt the UI and the problem seems to be gone. I don't know what the problem could have been.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants