Use esbuild Instead of Snowpack (and fix build error) #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR the project uses pnpm for lock file so could you remove the package-lock.json and update the lockfile |
Used corepack to install the latest pnpm, and regenerated the lock file. Removed the npm lock file. Husky v4 was not playing nicely with the latest pnpm, so I updated husky to the latest version and moved the pre-commit hook to .husky/pre-commit as v9 expects.
|
I've never used pnpm or corepack before, so let me know if anything is out of place. I think it should be correct though. Had to update husky as v4 was quite old and didn't work with pnpm. Thanks for taking a look at the PR |
|
Just realized I need to use pnpm in some more places, holding off on this for a sec. |
* Using plugins for esbuild:
- esbuild-plugin-copy
- esbuild-sass-plugin
- custom plugin to run tsc
* Upgraded concurrently and nodemon to latest versions.
* Updated package.json dev script:
- use pnpm
- nodemon: only watch build dir and config
- use --raw to get colors
* Don't serve 'assets' path (it no longer exists).
* Streamline html.ts route and use new build paths. Only need to import
one css file as it is being bundled.
* Update other middleware to use new paths
|
Okay, made a bunch of changes and started using esbuild in a better way. Important changes are called out in the commit message. Let me know if you want anything else changed |
|
@butlerx Anything I can do to help this PR move forward? Would be nice to use the fixes from 2.7.0 |
butlerx
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a new build system in place to replace Snowpack. It was failing to build so I fixed the build, and then moved to esbuild.
fixes #526
fixes #512
fixes #526
fixes #513
(many of these are duplicates)