Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder default meta tags attributes #54

Merged
merged 1 commit into from
May 8, 2023
Merged

Reorder default meta tags attributes #54

merged 1 commit into from
May 8, 2023

Conversation

imsus
Copy link
Contributor

@imsus imsus commented May 7, 2023 •
edited

Problem

Current meta tags default ordering is

  • title
  • meta description
  • keyword
  • charset
  • viewport

Based on best practice from https://speakerdeck.com/csswizardry/get-your-head-straight?slide=39 charset and viewport should come first then other meta tags

Solution

change charset + viewport meta tags to first then following others

@butschster butschster merged commit 92ffaa1 into butschster:master May 8, 2023
@butschster butschster self-requested a review May 8, 2023 07:23
@butschster butschster self-assigned this May 8, 2023
@butschster butschster added the enhancement New feature or request label May 8, 2023
@imsus imsus deleted the patch-1 branch May 15, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butschster butschster Awaiting requested review from butschster

Assignees

@butschster butschster

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imsus @butschster