Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got an error when trying to set a filter with "abc" #1261

Open
vkcorp opened this issue Dec 11, 2023 · 6 comments
Open

Got an error when trying to set a filter with "abc" #1261

vkcorp opened this issue Dec 11, 2023 · 6 comments

Comments

@vkcorp
Copy link

vkcorp commented Dec 11, 2023

To search with a filter, I tried to typed "abc",
and I got an error message when I try to set it, with below message.

Error
A fatal error has occurred - we're sorry this has happened. Please check out the details below in case they help diagnose the issue:

TypeError: Cannot read properties of undefined (reading 'substring')
    at Jn (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:400:20)
    at div
    at t (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:2:1256520)
    at t (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:2:1256975)
    at div
    at w (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:847698)
    at div
    at w (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:847698)
    at dr (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:459:2382)
    at div
    at s (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:2:1261307)
    at div
    at t (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:2:1262788)
    at div
    at s (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:2:1261307)
    at div
    at t (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:2:1262788)
    at div
    at w (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:847698)
    at Pi
    at ct (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:339:5661)
    at Rt (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:845758)
    at t.VaultEditor (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:755:51)
    at h (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:717:45)
    at div
    at w (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:847698)
    at t.SearchProvider (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:832:5141)
    at div
    at w (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:847698)
    at t.VaultManagement (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:766:64)
    at t (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:751673)
    at t (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:753676)
    at t (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:746789)
    at t (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:757470)
    at div
    at w (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:847698)
    at file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:925:1369405
    at Rt (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:845758)
    at Rt (file:///C:/Users/jungh/AppData/Local/Programs/Buttercup/resources/app.asar/build/renderer/index.js:654:845758)
    at t.App (file:///C:/Users/jungh/AppData/Local

When I typed a last letter 'c', it's happened.

I'm using :

Desktop @ v2.23.1
Core @ v7.4.0
Flags: installed
@perry-mitchell
Copy link
Member

I can't reproduce.. Are you able to create a new vault and test if it still happens?

image

@vkcorp
Copy link
Author

vkcorp commented Dec 14, 2023

Probably it's happened at one of my spcific group.
With new one, no problem.

image

@vkcorp
Copy link
Author

vkcorp commented Dec 14, 2023

Well, I guess I found item(s) which made this trouble.

If there is an item that doesn't have both Username and Password (but it have a custom field),
or No Username and only have a Password,
it makes this trouble.

With devtools, I tried to find one by one which made error screen,
and fixed those items with providing 'n/a' as new value
then no more problem now...

(Well, there was only key or id (as UUID) and no title, so it's not easy to find what item makes it.)

@vkcorp
Copy link
Author

vkcorp commented Dec 14, 2023

Actually I imported that group from JSON file,
and I guess some items were out of rules but didn't filtered.

@vkcorp
Copy link
Author

vkcorp commented Dec 14, 2023

Well, I tried to make new item which doesn't have Username and Password but have Custom fileld,
but it didn't make a trouble..
What a strange....

@Oxalin
Copy link
Contributor

Oxalin commented Jan 10, 2024

Even with this strange behaviour, I think Buttercup shouldn't crash and properly deal with the missing fields if that is possible. Ignoring the item would probably be a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants