-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhanded Error: spawn while updating #690
Comments
@blimmo Can you add/edit/remove files within |
I can do all of those things. Deleteing the |
Is it possible that Buttercup was installed with raised permission levels, like from an admin user or super user privileges? Would you mind uninstalling and reinstalling from a freshly-loaded version of say 1.10.3 so we can test the update functionality? |
Reinstalled from 1.10.3 and no change. I then tried 1.10.1 (last version autoupdates worked) and this worked! I'm now on 1.11.0. It seems that it's just updating from 1.10.2-3 (and possibly 1.11.0 but I can't test that yet) that's the problem. I'm happy to keep testing things if you need me to :) |
@blimmo @perry-mitchell I accidentally commented about this on the wrong thread 😂 electron-userland/electron-builder#1580 (comment) but that question is for @blimmo actually. Does this happen when you click on Download or does it happen when the app tries to check for updates? You can see that this is the same error that is mentioned in that issue. |
It's when I click download. I got an elevation prompt when it worked but the failing times seem to have missed that out somehow. |
I also get this all the time since a while back in time. So this time I'll speak out loud here.
|
Same happened on my W10 node and had to download/run the installer manually. This might be a W10 security measure. Defender did not recognise the manually downloaded installer and produced a warning which is different from user right elevation. |
As mentioned earlier it can be run from the temp folder - it causes a permission dialog to show and then it works normally. Running it from the command line fails as does the update process in the app. I think you’re right about it being a security precaution.
Definitely time to have the windows stuff signed properly I think.
|
I agree! I thought it was a bit weird to get a warning from Windows that this app may not be safe, because it's an app for just that, security. ☺ |
I'd say that this is then blocked by #704 |
I managed to update it once I ran buttercup as administrator. |
@MiloradFilipovic How awesome! I can confirm that it works! I will always run as administrator from now on... until it's fixed and I can recommend everyone else to do that as well. Thanks! |
Tried to upgrade Buttercup Desktop (with the built-in update check)
Looked closer to the installer file in the directory Understandably that this is related to the Windows code signing that you are working on to fix. |
Really appreciate the help and patience here. @sallar and I are looking at investing in a codesigning cert shortly so we can clear up some of these issues. We'll hopefully take a look at it tomorrow and over the next few days. |
Tried to update to 1.14.0 and the error still occurred. I can try updating manually this time and then hopefully future updates will work? |
This is expected since 1.13.0 is not code signed.
->
|
Same for 1.15.0 : why not allow user to set up a custom download directory ? |
Still occurring for me while doing the 1.15.0 -> 1.16.2 update |
Having the same issue with 1.15.0 -> 1.16.2 |
Whenever an update is released, I'm running the application as administrator , just for the update. Like others app, can't it just asking administrator's rights for upgrade time ? |
We’re using the update system that came with the platform, electron. While it could be a flag we’re missing, I attribute the issue to the update system not being a great fit for us. If we can’t easily find a fix for it we’ll probably turf it and find a new one.. |
Using the auto-updater I get this:
Started in 1.10.3 and I hoped it would sort itself out by the next update but it's still failing on 1.11.0
OS: Windows 10
The text was updated successfully, but these errors were encountered: