Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhanded Error: spawn while updating #690

Open
blimmo opened this issue Nov 15, 2018 · 26 comments
Open

Unhanded Error: spawn while updating #690

blimmo opened this issue Nov 15, 2018 · 26 comments

Comments

@blimmo
Copy link

blimmo commented Nov 15, 2018

Using the auto-updater I get this:

image

Started in 1.10.3 and I hoped it would sort itself out by the next update but it's still failing on 1.11.0

OS: Windows 10

@perry-mitchell
Copy link
Member

@blimmo Can you add/edit/remove files within C:\Users\Peter\AppData\Local\Temp\ ? Would be good to check if you can to see what the problem is. ACCES is obviously a permissions issue with your machine.

@blimmo
Copy link
Author

blimmo commented Nov 15, 2018

I can do all of those things. Deleteing the up-* folders has had no effect on the error.

@perry-mitchell
Copy link
Member

Is it possible that Buttercup was installed with raised permission levels, like from an admin user or super user privileges?

Would you mind uninstalling and reinstalling from a freshly-loaded version of say 1.10.3 so we can test the update functionality?

@blimmo
Copy link
Author

blimmo commented Nov 15, 2018

Reinstalled from 1.10.3 and no change.

I then tried 1.10.1 (last version autoupdates worked) and this worked! I'm now on 1.11.0.

It seems that it's just updating from 1.10.2-3 (and possibly 1.11.0 but I can't test that yet) that's the problem.

I'm happy to keep testing things if you need me to :)

@sallar
Copy link
Member

sallar commented Nov 16, 2018

@blimmo @perry-mitchell I accidentally commented about this on the wrong thread 😂 electron-userland/electron-builder#1580 (comment) but that question is for @blimmo actually. Does this happen when you click on Download or does it happen when the app tries to check for updates?

You can see that this is the same error that is mentioned in that issue.

@blimmo
Copy link
Author

blimmo commented Nov 16, 2018

It's when I click download. I got an elevation prompt when it worked but the failing times seem to have missed that out somehow.

@jenstornell
Copy link

I also get this all the time since a while back in time. So this time I'll speak out loud here.

  • It's the exact same error as the screenshot.
  • It's when pressing download as stated.
  • I tried to install it manually from the exe file. That worked, but new versions are released quite often so it's not a long term solution.
  • I'm on Windows 10.

@perry-mitchell
Copy link
Member

Also reproducible for me now:

image

@ghost
Copy link

ghost commented Nov 27, 2018

Same happened on my W10 node and had to download/run the installer manually. This might be a W10 security measure. Defender did not recognise the manually downloaded installer and produced a warning which is different from user right elevation.

@perry-mitchell
Copy link
Member

perry-mitchell commented Nov 27, 2018 via email

@jenstornell
Copy link

I agree! I thought it was a bit weird to get a warning from Windows that this app may not be safe, because it's an app for just that, security. ☺

@perry-mitchell
Copy link
Member

I'd say that this is then blocked by #704

@ghost
Copy link

ghost commented Nov 28, 2018

Just for completeness the Defender SmartScreen warning

defender smart screen warning

@MiloradFilipovic
Copy link

MiloradFilipovic commented Nov 30, 2018

I managed to update it once I ran buttercup as administrator.

@jenstornell
Copy link

@MiloradFilipovic How awesome! I can confirm that it works! I will always run as administrator from now on... until it's fixed and I can recommend everyone else to do that as well.

Thanks!

@d2s
Copy link
Contributor

d2s commented Dec 30, 2018

Tried to upgrade Buttercup Desktop (with the built-in update check)
from the version 1.11.x to version 1.13.0, and got the following error message.

Unhandled Error
Error: spawn C:/Users/UserName/AppData/Local/Temp/up-0t8Xtm/buttercup-desktop-setup-1.13.0.exe EACCES

Looked closer to the installer file in the directory
C:/Users/UserName/AppData/Local/Temp/up-0t8Xtm/
and found out that it seems to work properly when started directly.

Understandably that this is related to the Windows code signing that you are working on to fix.

@perry-mitchell
Copy link
Member

Really appreciate the help and patience here. @sallar and I are looking at investing in a codesigning cert shortly so we can clear up some of these issues. We'll hopefully take a look at it tomorrow and over the next few days.

@ghost
Copy link

ghost commented Jan 2, 2019

Since the code now being signed with v1.14.0 I guess will have to wait until the next update rolls out and see whether it sorts this issue.

Defender's SmartScreen seems not impressed though. Maybe the certificate needs to get propagated into the MS database.

defender smart screen

@blimmo
Copy link
Author

blimmo commented Jan 3, 2019

Tried to update to 1.14.0 and the error still occurred. I can try updating manually this time and then hopefully future updates will work?

@ghost
Copy link

ghost commented Jan 3, 2019

Tried to update to 1.14.0 and the error still occurred

This is expected since 1.13.0 is not code signed.

I can try updating manually this time and then hopefully future updates will work?

->

will have to wait until the next update rolls out and see whether it sorts this issue.

@jy95
Copy link

jy95 commented Feb 13, 2019

Same for 1.15.0 : why not allow user to set up a custom download directory ?

@ghost
Copy link

ghost commented Feb 13, 2019

confirmed

1 1 5

@blimmo
Copy link
Author

blimmo commented Jul 23, 2019

Still occurring for me while doing the 1.15.0 -> 1.16.2 update

@Blackfaded
Copy link

Having the same issue with 1.15.0 -> 1.16.2
Run application as administrator did work!

@Jib-san
Copy link

Jib-san commented Sep 8, 2019

Whenever an update is released, I'm running the application as administrator , just for the update.

Like others app, can't it just asking administrator's rights for upgrade time ?

@perry-mitchell
Copy link
Member

We’re using the update system that came with the platform, electron. While it could be a flag we’re missing, I attribute the issue to the update system not being a great fit for us. If we can’t easily find a fix for it we’ll probably turf it and find a new one..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants