Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak bundles fur alles #652

Merged
merged 11 commits into from
Jun 21, 2017
Merged

flatpak bundles fur alles #652

merged 11 commits into from
Jun 21, 2017

Conversation

xaiki
Copy link
Member

@xaiki xaiki commented Jun 18, 2017

Signed-off-by: Niv Sardi xaiki@evilgiggle.com

Fixes #559

Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
@xaiki xaiki force-pushed the xaiki/flatpak branch 14 times, most recently from bcb98e3 to d0f137e Compare June 18, 2017 14:03
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
waltervargas added 2 commits June 19, 2017 00:13
Fixes the command to trigger build using gulp from node_modules folder

TODO: Upload the GPG key of butter to travis

Tested-by: waltervargas <contact@walter.bio>
Signed-off-by: waltervargas <contact@walter.bio>
Adds Flatpak build support with docker
@xaiki xaiki force-pushed the xaiki/flatpak branch 3 times, most recently from f99b498 to 442bfdb Compare June 19, 2017 17:24
- hack in support for passphrase caching
- run our own gpg-agent

Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
@xaiki
Copy link
Member Author

xaiki commented Jun 19, 2017

this is ready ! review anyone ?
@waltervargas @vankasteelj ??

@xaiki xaiki requested a review from vankasteelj June 19, 2017 21:08
Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
gulpfile.js Outdated
gpgSign: '36534BDEC827CE08' // Gpg key to sign with
}, function (error) {
if (error) {
reject(error);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be: return reject(error);
I'm getting success message on error

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! good catch !

Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
@xaiki xaiki merged commit 5fa4171 into master Jun 21, 2017
@xaiki xaiki deleted the xaiki/flatpak branch June 21, 2017 05:45
@lil5 lil5 mentioned this pull request Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants