-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GitHub Action to Run Cypress #112
Conversation
COOKIE_SECRET: "foobar" | ||
MAILER_HOST: "foobar" | ||
MAILER_PORT: "321" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app wouldn't start unless I had these filled out, but these placeholders seem to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tech debt: let's run something like Sendria so these configured values are real within the testing environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ba671b2
to
52fdd29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the daemonization was intended. Let's fix that, document tech debt as new issues, and ship this
COOKIE_SECRET: "foobar" | ||
MAILER_HOST: "foobar" | ||
MAILER_PORT: "321" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tech debt: let's run something like Sendria so these configured values are real within the testing environment.
Co-authored-by: Alec Wenzowski <alec@button.is>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the Additional Notes:
Let's make sure we've got a tech debt card for our CI/CD process that notes our e2e tests should be booting the candidate docker image that we intend to release to production (as a 12 factor app, we should be able to boot the prod image with development
or test
environment flag set). The cypress errors appear to be due to the fact that we're running headless from inside a runner that does not have access to a gpu. There's probably a way to squelch these, so that should be tracked as tech debt as well. The npm run browserslist --update-db
call should probably also be part of our ci config so I'd track that as separate tech debt.
This PR addresses issue:#101
Includes tests? y
Rebased on main address to conflicts? y
Updated docs? y
Proposed changes:
Additional notes: