-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CWU CRUD Gov User Cypress Test #126
Conversation
2cfca31
to
8878b77
Compare
Highly recommend using Mailhog in ci/dev/test to create a fully functional smtp endpoint. Here's a good helm chart for Mailhog. |
In order to exclude Cypress tests from the Quality Gate on Sonar (a good idea because by definition end-to-end tests are verbose imperative code with a lot of repeated calls) we should follow the documentation to exclude these files. Once excluded I'd advocate for our Quality Gate to be in a passing state on the remaining code before we merge. |
Any chance we could get the Cypress Dashboard permissions set to public? When I click the link in the CI output I am not able to see the recorded run. Here's how to make a cypress Project public. |
Issue for this here: https://github.com/bcgov/digital_marketplace/pulls |
[10:55] Matthieu Foucault |
Co-authored-by: Alec Wenzowski <alec@button.is>
Cypress.on('uncaught:exception', (err, runnable) => { | ||
// returning false here prevents Cypress from | ||
// failing the test | ||
return false | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I grabbed this straight from the Cypress docs. This is to avoid app errors failing the tests, e.g.:
I've added a tech debt issue: bcgov#131
Tech debt issue here: https://github.com/button-inc/digital_marketplace/issues/133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! love the sonar cloud update 🚢
This PR addresses issue: #125 (test script I refer to below is in this issue)
Includes tests? y
Rebased on main address to conflicts? y
Updated docs? n/a
Proposed changes:
Additional notes:
[mailer] Unable to send email subject="A Code With Us Opportunity Has Been Cancelled"
. This happens because in development, the site uses gmail to test transactional emails in development. I gave it some fake gmail credentials because we don't care about the emails here.