update ci versions #65
Conversation
.secrets.baseline
Outdated
| @@ -114,5 +114,5 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "generated_at": "2021-12-08T00:06:35Z" | |||
| "generated_at": "2021-12-08T19:38:46Z" | |||
There was a problem hiding this comment.
No need to include this in the patch, I think
There was a problem hiding this comment.
@wenzowski, is there a way to un-include things like this without changing the commits and un-approving the PR?
There was a problem hiding this comment.
I believe our approval settings are currently to dismiss stale reviews every time there's a change in the commit manifest of the PR
| @@ -12,7 +12,7 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/setup-node@v2 | |||
| with: | |||
| node-version: '10' | |||
| node-version: '16' | |||
There was a problem hiding this comment.
This looks like continuation of #56 ...so I'd call the fact that we were able to bump the node version there and miss the CI configuration tech debt. Let's not hold back this PR but let's figure out how to ensure when we bump node versions in the future we get everything in one go–perhaps we should be looking at how other projects use a .tool-versions file as a source of truth that gets consumed by other systems, like docker, ci, npm, etc.
BCerki
force-pushed
the
64-update-ci-versions
branch
from
0c62ed6
to
5510581
Compare
Here: https://github.com/button-inc/digital_marketplace/issues/67 |
This PR: