Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow merchants to disable including ifa via features #29

Merged
merged 2 commits into from Jul 2, 2019
Merged

Allow merchants to disable including ifa via features #29

merged 2 commits into from Jul 2, 2019

Conversation

Jon6193
Copy link
Contributor

@Jon6193 Jon6193 commented Jul 1, 2019

Goals ⚽

Allow merchants to disable including ifa

Implementation 🚧

  • Added Features public interface
  • Added FeaturesImpl class to handle functionality

Testing 🔍

  • Added tests to verify changes

najmsheikh
najmsheikh approved these changes Jul 2, 2019
View reviewed changes
button-merchant/src/main/java/com/usebutton/merchant/module/Features.java Outdated
package com.usebutton.merchant.module;

/**
* Interface for features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Interface to allow configuration of Merchant Library features" ?

kirtanp98
kirtanp98 approved these changes Jul 2, 2019
View reviewed changes
Copy link

@kirtanp98 kirtanp98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Jon6193 Jon6193 merged commit b5f116a into master Jul 2, 2019
@Jon6193 Jon6193 deleted the jon/allow-disabling-including-ifa branch July 2, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@najmsheikh najmsheikh najmsheikh approved these changes

@kirtanp98 kirtanp98 kirtanp98 approved these changes

@ecgreb ecgreb Awaiting requested review from ecgreb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jon6193 @najmsheikh @kirtanp98