Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order model #14

Merged
merged 10 commits into from Jun 17, 2019
Merged

Update order model #14

merged 10 commits into from Jun 17, 2019

Conversation

kirtanp98
Copy link
Contributor

Goals 馃幆

Update the Order model with new properties. Additionally, deprecated the original initializer and the amount property.

Implementation Details 馃毀

Added the following properties:

  • purchase date
  • line items
  • source token
  • customer order id
  • customer

Testing Details 馃攳

Added unit tests for the Order model.

Source/Order.swift Outdated Show resolved Hide resolved
Source/Order.swift Outdated Show resolved Hide resolved
Source/Order.swift Outdated Show resolved Hide resolved
Source/Order.swift Outdated Show resolved Hide resolved
Copy link

@Jon6193 Jon6193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@romero-ios romero-ios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

ButtonMerchant.xcodeproj/project.pbxproj Show resolved Hide resolved
Source/Order.swift Outdated Show resolved Hide resolved
Source/Order.swift Outdated Show resolved Hide resolved
Source/Order.swift Outdated Show resolved Hide resolved
Tests/UnitTests/OrderTests.swift Show resolved Hide resolved
Copy link
Contributor

@paultopher paultopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once tests pass.

Source/Order.swift Outdated Show resolved Hide resolved
Source/Order.swift Outdated Show resolved Hide resolved
@romero-ios romero-ios merged commit 558d354 into master Jun 17, 2019
@kirtanp98 kirtanp98 deleted the update-order-model branch June 24, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants