Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow merchants to disable including IFA via features #27

Merged
merged 3 commits into from Jul 2, 2019
Merged

Allow merchants to disable including IFA via features #27

merged 3 commits into from Jul 2, 2019

Conversation

kirtanp98
Copy link
Contributor

Goals 馃幆

Allow merchants to enable including IFA.

Implementation Details 馃毀

  • Added Configurable protocol
  • Added features property to ButtonMerchant

Testing Details 馃攳

  • Added additional unit test for IFA

romero-ios
romero-ios approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@romero-ios romero-ios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left a non-blocking comment for adding a test

Jon6193
Jon6193 approved these changes Jul 2, 2019
View reviewed changes
Copy link

@Jon6193 Jon6193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kirtanp98 kirtanp98 merged commit 65aec63 into master Jul 2, 2019
@wessmith wessmith deleted the kirtan/allowing-disabling-IFA branch July 2, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jon6193 Jon6193 Jon6193 approved these changes

@romero-ios romero-ios romero-ios approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kirtanp98 @Jon6193 @romero-ios