CI with GH actions #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultopher
force-pushed
the
paul/gh_actions
branch
3 times, most recently
from
6a1a578
to
d8759ea
Compare
najmsheikh
reviewed
Aug 20, 2020
| - name: Run Tests | ||
| run: | | ||
| bundle exec fastlane test scheme:"UnitTests" | ||
| bundle exec fastlane test scheme:"IntegrationTests" |
There was a problem hiding this comment.
Does this automatically start the simulator?
najmsheikh
approved these changes
Aug 20, 2020
.github/workflows/ci.yml
Outdated
Comment on lines
32
to
37
| - name: Run Tests | ||
| run: | | ||
| bundle exec fastlane test scheme:"UnitTests" | ||
| bundle exec fastlane test scheme:"IntegrationTests" |
There was a problem hiding this comment.
Let's separate the unit tests from the integration test step so it's easier to grok later if something goes wrong
Suggested change
| - name: Run Tests | |
| run: | | |
| bundle exec fastlane test scheme:"UnitTests" | |
| bundle exec fastlane test scheme:"IntegrationTests" | |
| - name: Run Unit Tests | |
| run: bundle exec fastlane test scheme:"UnitTests" | |
| - name: Run Integration Tests | |
| run: bundle exec fastlane test scheme:"IntegrationTests" |
paultopher
force-pushed
the
paul/gh_actions
branch
from
d8759ea
to
f1501de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals 馃幆
Use Github Actions for CI