Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not for npm registry #22

Closed
ntkme opened this issue Jul 10, 2016 · 1 comment
Closed

Not for npm registry #22

ntkme opened this issue Jul 10, 2016 · 1 comment
Labels

Comments

@ntkme
Copy link
Contributor

ntkme commented Jul 10, 2016

Hi @Ostera,

I noted that you have published my project to npm registry. I don't know what's your intention of doing it, but I would like to friendly remind you that this project is not for npm:

  1. This project do use npm, but it is only for installing build dependencies.
  2. Octicons is included in this project as a git submodule, which is a more friendly way to keep the code base clean, deal with licensing, and use GitHub Pages. npm won't install git submodules.
  3. Due to a technical limitation (Allow usage with AMD/CommonJS #20), every single hosted copy of this project needs to change a hard-coded URL accordingly, while a real npm package should work out of box.

I will appreciate if you can unpublish this project from npm registry to avoid any further confusion.


P.S. I won't question your motives, as I don't see any violation of the license.

@ntkme ntkme added the question label Jul 10, 2016
@leostera
Copy link

Hi! I'm currently working on a refactor to make it possible to include the button generation code in other projects where the DOM elements might not be available at the time of including the source (I.e. A React app that would render the a corresponding to a Stars button after the parsing was done by the buttons.js file).

Granted, I jumped the gun on publishing to secure the namespace. I'll unpublish, fork, and republish so there's no confusion as to what is the source of the published module.

Thanks for bringing this to my attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants