Publish to npm registry

[hiendv]

https://www.npmjs.com/package/github-buttons

Security holding package
This package name is not currently in use, but was formerly occupied by another package. To avoid malicious use, npm is hanging on to the package name, but loosely, and we'll probably give it to you if you want it.

You may adopt this package by contacting support@npmjs.com and requesting the name.

[ntkme]

See #22. Basically some one posted this package, and I asked for removal.

[ntkme]

As for the current state of this project, it is ready to be published as npm package.

However, most of the users use it by embedding a script instead of using as module. I haven’t heard much requests to make it available in npm, which is why I haven’t published it.

I can look into reclaiming the package name and publishing it if there is such a demand.

For now it can be installed with the following command if you really want to, but I won’t recommend it:

npm install git+https://github.com/ntkme/github-buttons.git

[hiendv]

Understood. Well, for now you have my 👍 for the package name

[gavinr]

I'd like to see this as an NPM package so I can more easily use as a module. Consider this a 👍 vote :)

[erquhart]

most of the users use it by embedding a script instead of using as module

That's the only way to use it currently, so yeah that stands to reason. Publish it and you'll likely see npm downloads start climbing. Especially because yours is the only button with React/Vue components - React/Vue users pretty much always have a build system and dependency management via npm.

You're the owner so no one else can really do this but you. Would you mind sending an email to support@npmjs.com asking for the name?

[nezdemkovski]

I want it as npm module as well. Take my 👍, please

[ntkme]

OK. To really have this as a npm package, I'd like to do some change to the structure to this project first.

Today this project has two parts:

• The library: buttons.js
• The application: buttons.github.io

First, I will take them apart and have two separate repo.

Then the library hosted on buttons.github.io has to be versioned, and it might be a little bit more work on that. Otherwise it might break the <iframe> auto-sizing for older browsers that does not support shadow DOM when a stylesheet change happen in the future.

[nezdemkovski]

Hey @ntkme I can help you with that

[ntkme]

https://www.npmjs.com/package/github-buttons
https://unpkg.com/github-buttons@1.0.0/dist/

[ntkme]

For npm releases, to solve the versioning issue for iframe fallback for old browsers, I decided to use unpkg.com instead of GitHub Pages.

In npm release build (NODE_ENV=production):

  var name = "github-buttons";
  var version = "1.0.0";
  var baseURL = (/^http:/.test(location) ? "http" : "https") + "://" + ("unpkg.com/" + name + "@" + version + "/dist");