Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket features won't build on Windows #68

Closed
qdot opened this issue Dec 29, 2019 · 2 comments
Closed

Websocket features won't build on Windows #68

qdot opened this issue Dec 29, 2019 · 2 comments
Assignees
Labels
bug Connectors - Websocket Tasks/Bugs pertaining to the websocket connector module

Comments

@qdot
Copy link
Member

qdot commented Dec 29, 2019

Describe the bug
Websocket features won't build on windows, due to OpenSSL dependency. This is most likely an issue with the build system and getting the environment set up, since vendoring openssl-sys requires perl.

Additional context
We may move websocket libraries at some point (to something like https://github.com/sdroege/async-tungstenite) but since we'll need secure sockets no matter what, this will continue to be an issue.

@qdot qdot added the bug label Dec 29, 2019
@qdot qdot self-assigned this Dec 29, 2019
@qdot qdot added the Connectors - Websocket Tasks/Bugs pertaining to the websocket connector module label Dec 29, 2019
@blackspherefollower
Copy link
Collaborator

Build steps (from MSVC 64-bit cmd shell - not certain that was necessary though):

cd c:\git
git clone https://github.com/Microsoft/vcpkg.git
cd vcpkg
bootstrap-vcpkg.bat -disableMetrics
vcpkg install openssl:x64-windows
set OPENSSL_DIR=c:\git\vcpkg\installed\x64-windows
cd ..\buttplug-rs\buttplug
cargo test --features client-ws-ssl,winrt-ble

@qdot
Copy link
Member Author

qdot commented Jan 25, 2020

Added steps to README, will get added to CI at some point, but calling this working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Connectors - Websocket Tasks/Bugs pertaining to the websocket connector module
Projects
None yet
Development

No branches or pull requests

2 participants