Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror v0.1.0 refactoring #2

Merged
merged 10 commits into from
Oct 20, 2021
Merged

mirror v0.1.0 refactoring #2

merged 10 commits into from
Oct 20, 2021

Conversation

butuzov
Copy link
Owner

@butuzov butuzov commented Oct 3, 2021

work in progress

@viezly
Copy link

viezly bot commented Oct 3, 2021

This pull request is split into 5 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • cmd/internal/generate-tests
  • internal/checker
  • internal/imports
  • internal/rules
  • testdata

@coveralls
Copy link

coveralls commented Oct 4, 2021

Pull Request Test Coverage Report for Build 1353230104

  • 397 of 570 (69.65%) changed or added relevant lines in 9 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-21.9%) to 70.909%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checker/converter.go 18 28 64.29%
analyzer.go 161 188 85.64%
internal/checker/checker.go 114 144 79.17%
internal/checker/handlers.go 45 95 47.37%
internal/checker/types.go 38 94 40.43%
Files with Coverage Reduction New Missed Lines %
analyzer.go 3 86.43%
Totals Coverage Status
Change from base Build 1272060283: -21.9%
Covered Lines: 429
Relevant Lines: 605

💛 - Coveralls

@butuzov butuzov changed the title refactored version mirror v0.1.0 refactoring Oct 5, 2021
In this refactor i am adding technical debt of unoptimized code, in
order to get suggested fixes.
1) added `task tests`
2) updated $GOPKGS in makefile
@butuzov butuzov marked this pull request as ready for review October 18, 2021 08:17
@butuzov butuzov merged commit 961cc9f into main Oct 20, 2021
@butuzov butuzov deleted the candidate branch October 20, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants