Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring mirror so we can use analysis.SuggestedFixes #20

Merged
merged 3 commits into from
May 12, 2023
Merged

Conversation

butuzov
Copy link
Owner

@butuzov butuzov commented May 11, 2023

Planed Refactoring

Closes #4

- Simplified checker (instead of separate checekrs)
- Violations redone (& test generation)
- Fixed few mistakes in violations
@viezly
Copy link

viezly bot commented May 11, 2023

This pull request is split into 12 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • cmd/internal/generate-tests
  • internal/checker
  • testdata

@github-actions
Copy link

github-actions bot commented May 11, 2023

Pull Request Test Coverage Report for Build 4956097241

  • 170 of 176 (96.59%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+3.9%) to 94.203%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/checker/checker.go 45 51 88.24%
Files with Coverage Reduction New Missed Lines %
analyzer.go 2 95.92%
Totals Coverage Status
Change from base Build 4936303063: 3.9%
Covered Lines: 260
Relevant Lines: 276

💛 - Coveralls

@butuzov butuzov changed the title Refactoring mirror so we can use diagnostic.SuggestedFixes Refactoring mirror so we can use analysis.SuggestedFixes May 11, 2023
@butuzov butuzov merged commit 5e4827d into main May 12, 2023
@butuzov butuzov deleted the suggestions branch May 12, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions - Add way to transform suggestion into replacement
1 participant