Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functionality refactoring #6

Merged
merged 15 commits into from
May 8, 2023
Merged

functionality refactoring #6

merged 15 commits into from
May 8, 2023

Conversation

butuzov
Copy link
Owner

@butuzov butuzov commented May 3, 2023

No description provided.

@viezly
Copy link

viezly bot commented May 3, 2023

This pull request is split into 10 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • cmd/internal/generate-tests
  • internal/checker
  • internal/imports
  • testdata

@github-actions
Copy link

github-actions bot commented May 3, 2023

Pull Request Test Coverage Report for Build 4872116498

  • 146 of 176 (82.95%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+11.9%) to 82.813%

Changes Missing Coverage Covered Lines Changed/Added Lines %
analyzer.go 32 33 96.97%
internal/checker/violation.go 16 20 80.0%
internal/checker/imports.go 34 39 87.18%
internal/checker/checker.go 46 52 88.46%
debug.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
analyzer.go 1 96.83%
Totals Coverage Status
Change from base Build 1363014804: 11.9%
Covered Lines: 212
Relevant Lines: 256

💛 - Coveralls

@butuzov butuzov force-pushed the refactor branch 2 times, most recently from 43b172b to 23765c8 Compare May 7, 2023 07:05
1) fixed tests (copy/paste error)
2) refactored type checks
3) added `golangci-lint` example of output
@butuzov butuzov self-assigned this May 8, 2023
@butuzov butuzov merged commit 1e3ebec into main May 8, 2023
2 checks passed
@butuzov butuzov deleted the refactor branch May 8, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant