Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This extension breaks vimium's search #147

Closed
mijoharas opened this issue Dec 10, 2014 · 4 comments
Closed

This extension breaks vimium's search #147

mijoharas opened this issue Dec 10, 2014 · 4 comments

Comments

@mijoharas
Copy link
Contributor

cross posting this here, not sure what's causing this, details on how to repro here

@mijoharas mijoharas changed the title This extension manages to break vimium's search This extension breaks vimium's search Dec 10, 2014
@mrmr1993
Copy link

To quote my research from the Vimium bug:

...; on a fresh profile, running

window.find("p", false, true, true, false, true, false);window.getSelection();

gives different results depending on whether Octotree is enabled or not.

Since these are both natives and not overridden, something really screwy is going on here. Moreover, the selection after window.find is executed has type: "Caret", which is unexpected to say the least.

Good luck, I'm totally stumped. Seems like a Chromium bug, filing a report is probably the way to go.

@mrmr1993
Copy link

No longer stumped; user-select: none here is causing all the grief. I would question whether it's really necessary to stop a user from selecting the text in the sidebar.

This still feels like a Chromium issue -- the window.find function probably shouldn't "get stuck" in a -webkit-user-select: none element -- but there's an easy fix so I doubt much will come of it.

mijoharas added a commit to mijoharas/octotree that referenced this issue Dec 11, 2014
buunguyen added a commit that referenced this issue Dec 12, 2014
Removed user-select: none to fix #147
@buunguyen
Copy link
Collaborator

Thanks for working on this. I already merged and published this update to Chrome store.

@mijoharas
Copy link
Contributor Author

Thanks, fixes it for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants