Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octotree browses master when page browses commit #157

Closed
Topher-the-Geek opened this issue Jan 25, 2015 · 1 comment
Closed

Octotree browses master when page browses commit #157

Topher-the-Geek opened this issue Jan 25, 2015 · 1 comment

Comments

@Topher-the-Geek
Copy link

When browsing a branch (or tag), Octotree follows along. For example, if I use the branches/tags dropdown on the GitHub page to choose a branch (or tag), Octotree does the right thing.

branch

However, when browsing a commit, Octotree shows master. For example, if I click "Browse Tree" when looking at a CL in the history, Octotree shows master rather than the commit. Furthermore, clicking on directories and files in Octotree switches the URL to the master branch rather than the commit hash.

commit-hash

This is an awesome plugin! Small bugs aside.
@buunguyen buunguyen modified the milestones: 1.5.4, 1.6 Mar 6, 2015
@buunguyen
Copy link
Collaborator

Supported in 1.6 (releasing soon).

veelenga added a commit to veelenga/octotree that referenced this issue Apr 7, 2017
@veelenga
New fallback to extract branch/commit on github
16a8cc5 
Extracts from page title. Fixes ovity#157.

Examples of titles that match:

  * buunguyen/octotree at 2b63178
  * octotree/test at 2b63178 · buunguyen/octotree
  * octotree/docs at master · buunguyen/octotree

Examples of titles that do not match:

  * buunguyen/octotree: Code tree for GitHub
  * Fixed typo. (ovity#391) · ovity/octotree@8833647
@veelenga veelenga mentioned this issue Apr 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@buunguyen @Topher-the-Geek