Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<script>'s src not interpolated #638

Closed
zaiste opened this issue May 1, 2020 · 4 comments · Fixed by #639
Closed

<script>'s src not interpolated #638

zaiste opened this issue May 1, 2020 · 4 comments · Fixed by #639
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zaiste
Copy link
Contributor

zaiste commented May 1, 2020

In the following snippet the src attribute won't be interpolated:

<script type="text/javascript" src="/{ website.javascript }" />

while this one works:

<link rel="stylesheet" href="/{ website.stylesheet }">
@emilos emilos added bug Something isn't working good first issue Good for newcomers labels May 1, 2020
@emilos
Copy link
Contributor

emilos commented May 1, 2020

Thanks! It should be simple to add tags/script.js

@zaiste
Copy link
Contributor Author

zaiste commented May 1, 2020

@emilos not sure to understand, could you clarify ? :)

@emilos
Copy link
Contributor

emilos commented May 1, 2020 via email

@emilos
Copy link
Contributor

emilos commented May 2, 2020

@zaiste fixed here: https://github.com/buxlabs/boxwood/pull/639/files , released as v0.32.2. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants