Some changes #11
Open
Some changes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelan
commented
May 28, 2015
acelan
commented
- Rename the Config.php to Config.php.example, so that when you modify the config file, it won't lead to "changes to be committed" in git tree.
- add gitignore to ignore the config file, it contains private data, so it can prevent you from uploading your data to the server accidentally, and I also add the cache files to the gitignore.
- remove the cache files from git tree
replaced "Soprano" w/ "Standard" tuning, corrected baritone tuning from DBEA to DGBE
Delete "Soprano" from standard tuning, adjust format of baritone tuning accordingly
GCEA is not limited to Soprano size...
the last enabled option MUST NOT be followed by a comma, array format is {option1, option2, lastoption} - using {option1, option2, lastoption,} will break the array and cause json errors
added alternate ADF#B tuning
add ADF#B alternate tuning option
add ADF#B alternate tuning option
add ADF#B alternate tuning option
merge buzcarter commits
reverted previous commit, it should have been done in a new branch straight away
reverted previous commit
reverted previous commit
reverted previous commit
edited the sources and updated the merged & minified files as well - change should be ready to use (but is not fully tested - transposing chords in song editor seems to work)
Update ukeGeeks.definitions.sopranoUkuleleGcea.js
It leads to confilct when you set up your own site and modify the config file
ignore config and cache files
Conflicts: src/js/editor/ugsEditorPlus.actions.js src/js/editor/ugsEditorPlus.submenuUi.js ugsphp/views/song-editable.php
There are songs which has 1 char title, so it's unreasonable to have this kind of limitation, so remove it. Signed-off-by: AceLan Kao <acelan@acelan.idv.tw>
I wrote a script to convert songs from yoopu.me Signed-off-by: AceLan Kao <acelan@acelan.idv.tw>
Signed-off-by: AceLan Kao <acelan@acelan.idv.tw>
The filename string need urlencode(), or it will fail to load the file Signed-off-by: AceLan Kao <acelan@acelan.idv.tw>
Signed-off-by: AceLan Kao <acelan@acelan.idv.tw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.