Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites don't show on new layout #50

Closed
mat926 opened this issue Jul 6, 2021 · 7 comments
Closed

Sites don't show on new layout #50

mat926 opened this issue Jul 6, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@mat926
Copy link

mat926 commented Jul 6, 2021

On the new IMDB layout , sometimes the layout does not show , or I only see the cog icon.

https://www.imdb.com/title/tt0438488/

image

@arogl
Copy link

arogl commented Jul 7, 2021

Seeing similar issues in MSEdge DEV (win10 fully patch 21H1)and Tampermonkey (v2.13.0), and scripts updated manually to ensure the latest version.

@buzz buzz added the bug Something isn't working label Jul 7, 2021
@buzz
Copy link
Owner

buzz commented Jul 7, 2021

I can confirm this bug. I think there's a race condition. Elements that are drawn dynamically by the page are not available when the script injects its HTML. Solution is to wait until the elements are available on page.

@Purfview
Copy link

Purfview commented Jul 7, 2021

I think that problem is that some script reflows the page and custom elements disappear, I solved it by adding a dummy self-destructing element and observing when it disappears, then starting the script.
That reflow can happen at anytime, sometimes way after the 'load' event.

buzz added a commit that referenced this issue Jul 12, 2021
Try to alleviate display issues on new design.
@buzz
Copy link
Owner

buzz commented Jul 12, 2021

I can't reproduce this issue anymore. Does anyone still have this?
Nevertheless I moved the container element for the injection which might improve the situation.

buzz added a commit that referenced this issue Jul 12, 2021
@buzz
Copy link
Owner

buzz commented Jul 12, 2021

v2.0.9 is out which hopefully remedies the issue. Please report back if it works.

@mat926
Copy link
Author

mat926 commented Jul 12, 2021

Seems to be working now , thanks! I will update if it reoccurs.

@buzz
Copy link
Owner

buzz commented Jul 13, 2021

Closing for now. Please re-open if this bug appears again.

@buzz buzz closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants