sso: okta provider MVP #174

Jusshersmith · 2019-04-03T17:04:46Z

Okta provider integration

This implements the MVP for adding Okta as an oauth provider for SSO.
Documentation on set up of Okta resources in a separate PR: #182

This PR includes:

A new Okta provider (based off of the Google provider to keep them consistent where reasonable)
A set of tests for the Okta provider. Again, initially based off of the Google provider tests however changed/added to where necessary.
Changes to the options parsing layer to accommodate new settings required. (the only additional env var required that does not have a default is okta_org_url which is the URL of the org's okta domain (e.g. test.okta.com))
Now that we have multiple possible providers, some changes to the internal_util.go and it's tests package to separate logic into respective provider packages.
Minimum required changes to the google provider and google provider tests to work with the above changes to internal_util.go
Minimum required changes to provdider_default.go to work with the changes to internal_util.go

One notable thing missing is any group caching functionality - this will also be shipped in a separate, soon-to-come PR.

internal/auth/providers/internal_util.go

internal/auth/providers/okta.go

internal/auth/options.go

internal/auth/providers/okta.go

internal/auth/providers/provider_data.go

internal/auth/providers/okta.go

internal/auth/providers/google.go

internal/auth/providers/okta_test.go

internal/auth/providers/okta.go

jphines · 2019-04-22T17:27:57Z

@Jusshersmith this is looking really good, just a few nits about testing and arg validation!

validateToken validateToken, groups and email tidy validateToken UserInfo UserInfo continued Might be worth splitting this function up so it can serve different purposes if required in the future. However for now it does the job. some cleanup and fix group validation change default to google cleaning up updating comments removng BaseURL from provider for now removing BaseURL from options and modifying UserInfoURL and RevokeURL fix tags removing BaseURL from provider_data add offline_access for refresh token tidying add empty line back in separate validateToken into respective provider packages review changes change from oktapreview to okta rename UserInfo to GetUserProfile removing validateToken func and tests extra oktapreview -> okta add initial test file skipping while debugging fixing TestValidateEndpoint tests removing skip check response contents to properly validate removing debug output changes from review, and adding relevant test case use test logger instead of stdlib logger use %q instead of %s to quote formatted output moving formatting to options.go, and reducing repetition move logic to more relevant function set entire org url rather than just org name fixing test

Jusshersmith force-pushed the jusshersmith-okta-provider-test branch from a491f74 to 6d26a94 Compare April 10, 2019 17:13

jphines reviewed Apr 11, 2019

View reviewed changes

internal/auth/providers/internal_util.go Outdated Show resolved Hide resolved

jphines reviewed Apr 11, 2019

View reviewed changes

internal/auth/providers/okta.go Outdated Show resolved Hide resolved

Jusshersmith marked this pull request as ready for review April 15, 2019 10:40