Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: build from go 1.12 #225

Merged
merged 1 commit into from Jul 18, 2019
Merged

Conversation

cameronattard
Copy link
Contributor

Problem

httputil.ReverseProxy doesn't support WebSockets in go 1.11.

Solution

Build binaries using go 1.12.

Notes

I'm not sure if any additional changes are required to get WebSockets to work, but this is a start.

#103
https://go-review.googlesource.com/c/go/+/146437

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   62.23%   62.23%           
=======================================
  Files          50       50           
  Lines        4067     4067           
=======================================
  Hits         2531     2531           
  Misses       1349     1349           
  Partials      187      187

@Jusshersmith
Copy link
Contributor

Hey @cameronattard.

Thanks for sending this through! I’m working on validating this change now.

@Jusshersmith
Copy link
Contributor

Thanks again for the contribution @cameronattard!

@Jusshersmith Jusshersmith merged commit fd89bd8 into buzzfeed:master Jul 18, 2019
@cameronattard
Copy link
Contributor Author

Thanks @Jusshersmith. Is there a revised ETA for the next release?

@Jusshersmith
Copy link
Contributor

Hey @cameronattard - apologies for the delay of this release. We're aiming to release it any day now (by EOD tomorrow most likely), but I'll let you know if that changes.

Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants