sso_proxy: Add comment marking private key as test data #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite this key being stored in a `testdata` directory, we've received a number of reports highlighting that a private key is present in the SSO Repo. PEM format means anything outside of the `--- BEGIN ---` and `-- END ---`` block will be ignored, so it's safe to add a descriptive comment explaining that yes, this really is test data and its intentionally public!
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 62.14% 62.14%
=======================================
Files 53 53
Lines 4169 4169
=======================================
Hits 2591 2591
Misses 1391 1391
Partials 187 187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Despite this key being stored in a
testdatadirectory, we've received a number of reports highlighting that a private key is present in the SSO Repo.Solution
PEM format means anything outside of the
--- BEGIN PRIVATE KEY---and `-- END PRIVATE KEY ---`` block will be ignored, so it's safe to add a descriptive comment explaining that yes, this really is test data and its intentionally public!