Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused mut #136

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Remove unused mut #136

merged 1 commit into from
Aug 18, 2023

Conversation

MilesCranmer
Copy link
Contributor

FYI I'm not sure if this is correct or not, but cargo told me to submit this fix:

warning: variable does not need to be mutable
   --> src/metrics/mod.rs:663:17
    |
663 | ...   let mut zd = self.disks.entry(name).or_insert(ZDisk::fro...
    |           ----^^
    |           |
    |           help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

warning: variable does not need to be mutable
   --> src/metrics/mod.rs:728:13
    |
728 |         let mut overall = self
    |             ----^^^^^^^
    |             |
    |             help: remove this `mut`

@bvaisvil bvaisvil self-assigned this Aug 17, 2023
@bvaisvil
Copy link
Owner

Thanks for the PR. I think it's probably right. The reference does not need to be mutable.

@bvaisvil bvaisvil merged commit 642140e into bvaisvil:master Aug 18, 2023
4 checks passed
@MilesCranmer MilesCranmer deleted the patch-1 branch August 19, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants