-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement grace period for process selection #48
Conversation
…list is not reordered
This looks great! I really like the event processing refactor. Eventually, I'd like to move all event processes into their own file (maybe In my testing the 3000 ms time works as expected. I'm happy if we leave it as is. However, I did find one issue. After filtering the process table with I think what happens is when Other than that one issue, looks very good and thank you for the contribution! |
I can see the problem, thanks for the testing to find it! Tbh, i don't exactly understand why the up/down keys are not swallowed in the original version. It would probably be worth adding some unittests to this area when event processing gets moved to |
…rrow keys during filtering
I was preparing another refactoring and cleanup PR after this one. For now, i just split apart the inner match. Moving different sections of input handling to their own function is definitely something to do, but i would rather do it by input "mode" first, so there could be handling for keys when filtering, handling for keys during non-filtering, and handling for keys that work for both. |
That would be great. Looking forward to that.
Great. I tried your latest updates and everything works as expected. Thanks! |
Fixes #47
This mostly refactors the event handling to use pattern matching and fewer indent levels, and adds a selection grace period.
Right now it's hardcoded to 2000ms, so the actual observed interval by the user will be [2000ms, 4000ms]. This feels ok to me, but you may also want to test it.