Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore terminal on exit #63

Merged
merged 1 commit into from Aug 16, 2020
Merged

Restore terminal on exit #63

merged 1 commit into from Aug 16, 2020

Conversation

samoylovfp
Copy link
Contributor

@samoylovfp samoylovfp commented Aug 14, 2020

When exiting because of existing lock file, zenith messes up the terminal.
E.G. On oh-my-zsh with p10k in gnome-ternimal the cursor disappears.

@samoylovfp samoylovfp changed the title Restore terminal on exit [wip] Restore terminal on exit Aug 14, 2020
@samoylovfp
Copy link
Contributor Author

samoylovfp commented Aug 14, 2020

Apparently it is not that simple, this restore_terminal call eats the message about lock file being present.

Solved with restoring the terminal first and then printing the message. This works

When exiting because of existing lock file, zenith messes up the terminal.
On oh-my-zsh with p10k in gnome-ternimal the cursor disappears.
@samoylovfp samoylovfp changed the title [wip] Restore terminal on exit Restore terminal on exit Aug 14, 2020
@bvaisvil
Copy link
Owner

Thanks for this I'll take a look.

@bvaisvil bvaisvil merged commit aac86de into bvaisvil:master Aug 16, 2020
@samoylovfp samoylovfp deleted the patch-1 branch August 17, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants