Skip to content

Commit

Permalink
Merge branch 'io_uring-6.1' into for-next
Browse files Browse the repository at this point in the history
* io_uring-6.1:
  io_uring/rw: ensure kiocb_end_write() is always called
  • Loading branch information
axboe committed Oct 11, 2022
2 parents 7dc30bd + 613938f commit 6f1111b
Showing 1 changed file with 29 additions and 9 deletions.
38 changes: 29 additions & 9 deletions io_uring/rw.c
Expand Up @@ -234,11 +234,34 @@ static void kiocb_end_write(struct io_kiocb *req)
}
}

/*
* Trigger the notifications after having done some IO, and finish the write
* accounting, if any.
*/
static void io_req_io_end(struct io_kiocb *req)
{
struct io_rw *rw = io_kiocb_to_cmd(req, struct io_rw);

WARN_ON(!in_task());

if (rw->kiocb.ki_flags & IOCB_WRITE) {
kiocb_end_write(req);
fsnotify_modify(req->file);
} else {
fsnotify_access(req->file);
}
}

static bool __io_complete_rw_common(struct io_kiocb *req, long res)
{
if (unlikely(res != req->cqe.res)) {
if ((res == -EAGAIN || res == -EOPNOTSUPP) &&
io_rw_should_reissue(req)) {
/*
* Reissue will start accounting again, finish the
* current cycle.
*/
io_req_io_end(req);
req->flags |= REQ_F_REISSUE | REQ_F_PARTIAL_IO;
return true;
}
Expand All @@ -264,15 +287,7 @@ static inline int io_fixup_rw_res(struct io_kiocb *req, long res)

static void io_req_rw_complete(struct io_kiocb *req, bool *locked)
{
struct io_rw *rw = io_kiocb_to_cmd(req, struct io_rw);

if (rw->kiocb.ki_flags & IOCB_WRITE) {
kiocb_end_write(req);
fsnotify_modify(req->file);
} else {
fsnotify_access(req->file);
}

io_req_io_end(req);
io_req_task_complete(req, locked);
}

Expand Down Expand Up @@ -317,6 +332,11 @@ static int kiocb_done(struct io_kiocb *req, ssize_t ret,
req->file->f_pos = rw->kiocb.ki_pos;
if (ret >= 0 && (rw->kiocb.ki_complete == io_complete_rw)) {
if (!__io_complete_rw_common(req, ret)) {
/*
* Safe to call io_end from here as we're inline
* from the submission path.
*/
io_req_io_end(req);
io_req_set_res(req, final_ret,
io_put_kbuf(req, issue_flags));
return IOU_OK;
Expand Down

0 comments on commit 6f1111b

Please sign in to comment.