-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero length matches #6
Conversation
@@ -10,7 +10,7 @@ | |||
"lint": "standard", | |||
"prebuild": "rimraf dist", | |||
"prepublish": "npm run build", | |||
"test": "mocha --compilers js:babel-register 'src/**/*.test.js'" | |||
"test": "mocha --compilers js:babel-register \"src/**/*.test.js\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Fix test pattern for Windows users, see mochajs/mocha#2895 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Do I need to make any changes to bvaughn/react-highlight-words to pick up a new version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 😄
No, you shouldn't need to since this can go into a bugfix release. It should just be picked up by default. |
Published via 1.1.2 |
Just bumped the demo to use this version |
Thanks |
This fixes bvaughn/react-highlight-words#12