-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show "context" for classes without either contextType or contextTypes #368
Comments
I'll take over this one 👍 |
Please hold off for now. Im in the process of merging this repo into the main React repo (facebook/react#16381) and it might be tricky to import PRs that come in while this is in progress. 😄 Thanks for the offer, and we'll be happy to accept the contribution once the migration is done. |
Sure thing. 👍 |
You can still start work and send a PR, but you'll have to re-submit it to a proper place later. |
Merging might also be tricky, as a bunch of files are being moved around. Just thought it would be easier to wait a couple of days 😄 |
I don't mean it would be on you to merge :-) I'm thinking @hristo-kanchev can do the work and send a PR. Then we can ask him to copy paste the specific files he touched, find their new places in React repo, and send a PR there. That shouldn't involve putting more work on your plate. |
Nah, I didn't take it that way. I just wanted to safe Hristo the hassle of merging 😄 |
Nice idea @gaearon . I'll prepare the code and get it ready for submission once we merge DevTools in the main react repo. |
This repository is being merged into the main React repo (github.com/facebook/react). As part of this, I am moving all issues to that repository as well and closing them here. This issue has been relocated to: |
The text was updated successfully, but these errors were encountered: