Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show "context" for classes without either contextType or contextTypes #368

Closed
gaearon opened this issue Aug 7, 2019 · 9 comments
Closed
Labels
😎 enhancement New feature or request

Comments

@gaearon
Copy link
Collaborator

gaearon commented Aug 7, 2019

  • Don't show "context" for classes without either contextType or contextTypes
  • For classes with contextTypes, change the label to "legacy context" instead
@gaearon gaearon added the 😎 enhancement New feature or request label Aug 7, 2019
@hristo-kanchev
Copy link
Contributor

I'll take over this one 👍

@bvaughn
Copy link
Owner

bvaughn commented Aug 14, 2019

Please hold off for now. Im in the process of merging this repo into the main React repo (facebook/react#16381) and it might be tricky to import PRs that come in while this is in progress. 😄

Thanks for the offer, and we'll be happy to accept the contribution once the migration is done.

@hristo-kanchev
Copy link
Contributor

Sure thing. 👍

@gaearon
Copy link
Collaborator Author

gaearon commented Aug 15, 2019

You can still start work and send a PR, but you'll have to re-submit it to a proper place later.

@bvaughn
Copy link
Owner

bvaughn commented Aug 15, 2019

Merging might also be tricky, as a bunch of files are being moved around. Just thought it would be easier to wait a couple of days 😄

@gaearon
Copy link
Collaborator Author

gaearon commented Aug 15, 2019

I don't mean it would be on you to merge :-)

I'm thinking @hristo-kanchev can do the work and send a PR. Then we can ask him to copy paste the specific files he touched, find their new places in React repo, and send a PR there. That shouldn't involve putting more work on your plate.

@bvaughn
Copy link
Owner

bvaughn commented Aug 15, 2019

Nah, I didn't take it that way. I just wanted to safe Hristo the hassle of merging 😄

@hristo-kanchev
Copy link
Contributor

hristo-kanchev commented Aug 16, 2019

Nice idea @gaearon . I'll prepare the code and get it ready for submission once we merge DevTools in the main react repo.

@bvaughn
Copy link
Owner

bvaughn commented Aug 19, 2019

This repository is being merged into the main React repo (github.com/facebook/react). As part of this, I am moving all issues to that repository as well and closing them here.

This issue has been relocated to:
facebook/react#16466

@bvaughn bvaughn closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😎 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants