Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools: Don't show "context" for classes without either contextType or contextTypes #16466

Closed
bvaughn opened this issue Aug 19, 2019 · 3 comments · Fixed by #16617
Closed

DevTools: Don't show "context" for classes without either contextType or contextTypes #16466

bvaughn opened this issue Aug 19, 2019 · 3 comments · Fixed by #16617
Labels
Component: Developer Tools good first issue (taken) Type: Enhancement

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Aug 19, 2019

  • Don't show "context" for classes without either contextType or contextTypes
  • For classes with contextTypes, change the label to "legacy context" instead

Originally reported by @gaearon via bvaughn/react-devtools-experimental#368
@bvaughn bvaughn mentioned this issue Aug 19, 2019
Closed
@hristo-kanchev
Copy link
Contributor

hristo-kanchev commented Aug 21, 2019 •
edited
Loading

I'm working on this one.

Just clarifying if anyone else is looking at this atm.

@hristo-kanchev
Copy link
Contributor

@bvaughn I've fixed the issue. Once we merge the DevTools in master, I'll create the PR. 🚀

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 21, 2019

Thanks @hristo-kanchev. I'll do my best to get #16381 merged as soon as possible.

@hristo-kanchev hristo-kanchev mentioned this issue Aug 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Developer Tools good first issue (taken) Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DevTools] [Context] Legacy Context hristo-kanchev/react
2 participants
@bvaughn @hristo-kanchev