ci(eslint): use eslint+prettier with ci strictly (#165)

* ci(eslint): use eslint+prettier with ci strictly
* Fixed all warnings

---------

Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>

.eslintignore

@@ -0,0 +1 @@
+dist

.eslintrc.js

@@ -0,0 +1,35 @@
+module.exports = {
+  root: true,
+  env: {
+    browser: true,
+    es2021: true,
+  },
+  extends: [
+    "plugin:react/recommended",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:prettier/recommended",
+  ],
+  overrides: [
+    {
+      env: {
+        node: true,
+      },
+      files: [".eslintrc.{js,cjs}"],
+      parserOptions: {
+        sourceType: "script",
+      },
+    },
+  ],
+  parser: "@typescript-eslint/parser",
+  parserOptions: {
+    ecmaVersion: "latest",
+    sourceType: "module",
+  },
+  plugins: ["react"],
+  rules: {
+    "react/no-did-update-set-state": "off",
+    "react/react-in-jsx-scope": "off",
+    "react/prop-types": "off",
+    "@typescript-eslint/no-explicit-any": "off",
+  },
+};

.github/workflows/jest.yml → .github/workflows/ci.yml

@@ -1,8 +1,15 @@
-name: "Jest unit tests"
-on: [pull_request]
+name: CI
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+
 jobs:
-  tests-e2e:
+  ci:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        command: ['pnpm lint', 'pnpm typescript', 'pnpm test']
     steps:
       - uses: actions/checkout@v3
       - uses: pnpm/action-setup@v2
@@ -13,9 +20,7 @@ jobs:
           cache: "pnpm"
           cache-dependency-path: "pnpm-lock.yaml"
           node-version-file: ".nvmrc"
-      - name: Install dependencies
-        run: pnpm install
-      - name: Build NPM packages
-        run: pnpm run prerelease
-      - name: Run tests
-        run: pnpm run test
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm prerelease
+      - name: Run cis
+        run: ${{ matrix.command }}

.prettierrc.json

@@ -2,5 +2,12 @@
   "trailingComma": "es5",
   "tabWidth": 2,
   "semi": true,
-  "singleQuote": false
+  "singleQuote": false,
+  "arrowParens": "always",
+  "bracketSameLine": false,
+  "bracketSpacing": true,
+  "endOfLine": "lf",
+  "jsxSingleQuote": false,
+  "proseWrap": "preserve",
+  "quoteProps": "as-needed"
 }

package.json

@@ -44,8 +44,8 @@
     "clear:builds": "rm -rf ./dist",
     "clear:node_modules": "rm -rf ./node_modules",
     "prerelease": "preconstruct build",
-    "prettier": "prettier --write \"**/*.{css,html,js,json,jsx,ts,tsx}\"",
-    "prettier:ci": "prettier --check \"**/*.{css,html,js,json,jsx,ts,tsx}\"",
+    "lint": "eslint .",
+    "lint:fix": "eslint . --fix",
     "test": "jest",
     "test:watch": "jest --watch",
     "typescript": "tsc --noEmit",
@@ -58,12 +58,20 @@
     "@babel/preset-env": "^7.22.5",
     "@babel/preset-typescript": "^7.21.5",
     "@preconstruct/cli": "^2.8.1",
+    "@types/assert": "^1.5.10",
     "@types/jest": "^26.0.15",
     "@types/react": "^18",
     "@types/react-dom": "^18",
+    "@typescript-eslint/eslint-plugin": "^5.52.0",
+    "assert": "^2.0.0",
+    "eslint": "^8.0.1",
+    "eslint-config-prettier": "^9.0.0",
+    "eslint-plugin-import": "^2.25.2",
+    "eslint-plugin-prettier": "^5.0.0",
+    "eslint-plugin-react": "^7.33.1",
     "jest": "^29.4.3",
     "jest-environment-jsdom": "^29.4.3",
-    "prettier": "^2.8.6",
+    "prettier": "^3.0.1",
     "react": "^18",
     "react-dom": "^18",
     "ts-jest": "^29.0.5",
@@ -72,14 +80,6 @@
   "peerDependencies": {
     "react": ">=16.13.1"
   },
-  "eslintConfig": {
-    "extends": "./node_modules/kcd-scripts/eslint.js",
-    "rules": {
-      "react/prop-types": "off",
-      "react/no-did-update-set-state": "off",
-      "babel/no-unused-expressions": "off"
-    }
-  },
   "preconstruct": {
     "exports": {
       "importConditionDefaultExport": "default"