Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a friendlier default error component #15

Closed
graingert opened this issue May 15, 2018 · 4 comments · Fixed by #46
Closed

a friendlier default error component #15

graingert opened this issue May 15, 2018 · 4 comments · Fixed by #46
Labels
enhancement help wanted released

Comments

@graingert
Copy link

react-error-overlay gives all sorts of nice details about the error.

A big red unhappy face lowers moral!
@bvaughn
Copy link
Owner

bvaughn commented May 15, 2018 •
edited

react-error-overlay runs within the larger context of create-react-app, and has more info to show in its (DEV mode only) overlay than this component would. All this component has is the information React passes to componentDidCatch (an error message and a component stack).

If you'd like to put together a PR that shows this information in a better way, please feel free. I didn't assume anyone would use the built-in overlay to be honest. It's customizable for a reason. 😄

@graingert
Copy link
Author

I used the default because it was the minimal amount of effort to get something working!

@kentcdodds
Copy link
Collaborator

We're dropping support for the default fallback.

kentcdodds added a commit that referenced this issue Apr 30, 2020
@kentcdodds
feat: add resetErrorBoundary (and renderFallback)
49e7ca7 
Closes #26
Closes #15
Closes #34

BREAKING CHANGE: No longer support default FallbackComponent.
BREAKING CHANGE: Codebase is no longer written in Flow so flowtypes are no longer available (for now).
@kentcdodds kentcdodds mentioned this issue Apr 30, 2020
Merged
kentcdodds added a commit that referenced this issue Apr 30, 2020
@kentcdodds
feat: support resetting the error state (#46)
c38c84b 
Closes #26 
Closes #15 
Closes #34 

BREAKING CHANGE: No longer support default FallbackComponent.
BREAKING CHANGE: Codebase is no longer written in Flow so flowtypes are no longer available (currently).
@kentcdodds
Copy link
Collaborator

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add reset on re-render bvaughn/react-error-boundary
3 participants
@bvaughn @graingert @kentcdodds